Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go: upgrade deps #42

Merged
merged 2 commits into from
Aug 10, 2021
Merged

go: upgrade deps #42

merged 2 commits into from
Aug 10, 2021

Conversation

lrstanley
Copy link
Collaborator

closes #35

@lrstanley
Copy link
Collaborator Author

Also, I believe with later Go versions, vendor/ is no longer needed, given https://proxy.golang.org/ exists, and is now a standard and is the default location where packages are fetched from, it should mostly eliminate the need for any kind of vendor directory.

If you're fine with me removing this directory, I can remove it as well.

@favadi
Copy link
Owner

favadi commented Aug 10, 2021

If you're fine with me removing this directory, I can remove it as well.

This would be great!

@lrstanley
Copy link
Collaborator Author

Removed the vendor/ dir, as well as bumped Go from 1.13 to 1.16 in go.mod & your travis config. Tested successfully locally.

@favadi favadi merged commit 8dfc534 into favadi:master Aug 10, 2021
@favadi
Copy link
Owner

favadi commented Aug 10, 2021

Merged, thank @lrstanley

@lrstanley lrstanley deleted the feature/upgrade-deps branch August 10, 2021 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to latest golang Protobuf lib
2 participants