Reset error-related attributes of a background migration job when ret…

…rying
fatkodima · Mar 2, 2024 · 9cebfd0 · 9cebfd0
1 parent d956069
commit 9cebfd0
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/lib/online_migrations/background_migrations/migration_job.rb b/lib/online_migrations/background_migrations/migration_job.rb
@@ -73,7 +73,10 @@ def retry
           status: self.class.statuses[:enqueued],
           attempts: 0,
           started_at: nil,
-          finished_at: nil
+          finished_at: nil,
+          error_class: nil,
+          error_message: nil,
+          backtrace: nil
         )
       end
 

diff --git a/test/background_migrations/migration_job_test.rb b/test/background_migrations/migration_job_test.rb
@@ -70,6 +70,9 @@ def test_retry
       assert_equal 0, j.attempts
       assert_nil j.started_at
       assert_nil j.finished_at
+      assert_nil j.error_class
+      assert_nil j.error_message
+      assert_nil j.backtrace
     end
 
     private