Hash#update() vs Hash#[]= #195
Conversation
|
|
||
| def slow | ||
| ENUM.each_with_object({}) do |e, h| | ||
| h.update(e => e) |
There was a problem hiding this comment.
Here you create an additional Hash object which of curse will be much slower than only provide two "static" parameters as for Hash#[].
There was a problem hiding this comment.
Agree but keeping it similar to its alias Hash#merge!
There was a problem hiding this comment.
Can you please guide me, how to go about it?
There was a problem hiding this comment.
well it's obviously slower - i guess that's the whole point of this test?
looks fine to me 🌵
There was a problem hiding this comment.
Thank you @krtschmr As a next step can the Travis CI build be run for this PR and if everything looks good could this PR be considered for next release?
There was a problem hiding this comment.
i have nothing to say here. i feel this repo is a bit inactive 🤷🏿
There was a problem hiding this comment.
I understand, can it atleast be merged into the master branch? As its not a breaking change.
|
Fasterer PR DamirSvrtan/fasterer#92 has a dependency on this one. It would be very helpful if this PR gets merged in. Thanks. |
Hash#update is an alias for Hash#merge!. Ergo, the comparision between Hash#update and Hash#[]= should have similar outcome.
Ref #194