docs: add HeroDevs support banners to specific pages. Add new menu item. #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eomm
reviewed
Oct 6, 2024
|
Yes, will do.
…On Sun, Oct 6, 2024 at 9:38 AM Manuel Spigolon ***@***.***> wrote:
***@***.**** commented on this pull request.
Could you run the linter to get a green run&deploy?
/home/runner/work/website/website/src/theme/DocPage/index.js
Error: 79:10 error 'LatestVersionSuggestionLabel' is defined but never used no-unused-vars
—
Reply to this email directly, view it on GitHub
<#252 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BE3WQBIPSKUN2RRWDSPNNIDZ2FKPFAVCNFSM6AAAAABPMRL5QSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDGNJQGU2TMMRYHE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
AndreAngelantoni
changed the title
|
|
Uzlopak
reviewed
Oct 9, 2024
src/theme/DocVersionBanner/index.js
Outdated
| @@ -0,0 +1,126 @@ | |||
| /** | |||
There was a problem hiding this comment.
Why is that facebook copyright?
|
Not part of our PR...sorry, couldn't tell you.
…On Wed, Oct 9, 2024 at 1:45 PM Aras Abbasi ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In src/theme/DocVersionBanner/index.js
<#252 (comment)>:
> @@ -0,0 +1,126 @@
+/**
Why is that facebook copyright?
—
Reply to this email directly, view it on GitHub
<#252 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BE3WQBJWSB5D5NIRDGTCUVLZ2WBWHAVCNFSM6AAAAABPMRL5QSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDGNJYGE3DSOJUGY>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
@AndreAngelantoni it's 100% part of your PR. |
|
Ok, I'll look into it.
…On Thu, Oct 10, 2024 at 1:40 AM Matteo Collina ***@***.***> wrote:
@AndreAngelantoni <https://github.com/AndreAngelantoni> it's 100% part of
your PR.
—
Reply to this email directly, view it on GitHub
<#252 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/BE3WQBMXEN63I3EHOIOGCYDZ2YVODAVCNFSM6AAAAABPMRL5QSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMBUGMYTKMRXGY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
AndreAngelantoni
requested a deployment
to
staging
GitHub Actions
Waiting
|
My apologies, I thought that was for something else. That was added by the Swizzler tool and has now been removed. Looking into the HTML detritus next. |
|
I'm seeing this extra HTML in the current production docs: I can certainly remove it as part of this PR but perhaps someone had intentions for it? (This is what I thought the other comment was referring to. Again, my apologies.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR does the following:
The banners seemed to require swizzling the existing pages. If that wasn't correct, please advise.
Related Issues
Addresses fastify/fastify#5623.
Check List