Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test assertions #92

Merged
merged 4 commits into from
Jan 21, 2021
Merged

Fix test assertions #92

merged 4 commits into from
Jan 21, 2021

Conversation

Fdawgs
Copy link
Member

@Fdawgs Fdawgs commented Jan 18, 2021 •
edited
Loading

Main purpose of this commit is to fix expect statements being outside of it blocks.
expects aren't executed outside of it or test blocks.

Checklist

Frazer Smith added 4 commits January 18, 2021 15:06
test: rename tests with identical titles
0e07a9f 
Having identical titles for two different tests or test suites may create confusion
test: remove empty test with no assertions
6d66c92
test: move expect assertions inside it block
b705886 
expects do not execute outside of an `it` or `test` block
chore: remove commented out tests
79798e1
mcollina
mcollina approved these changes Jan 18, 2021
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@aboutlo aboutlo merged commit 03d4dd1 into fastify:master Jan 21, 2021
@Fdawgs Fdawgs deleted the test/tidy branch January 21, 2021 21:00
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Fdawgs @mcollina @aboutlo