Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI workflows #91

Merged
merged 8 commits into from
Jan 21, 2021
Merged

Update CI workflows #91

merged 8 commits into from
Jan 21, 2021

Conversation

Fdawgs
Copy link
Member

@Fdawgs Fdawgs commented Jan 18, 2021

Hi there!

This pull request is focused on the CI workflow in this repo, enabling dependabot automatic updates of dependencies, and laying the ground work to be able to fix the coveralls badge as highlighted in #28

Checklist

@aboutlo
Copy link
Collaborator

aboutlo commented Jan 18, 2021

@Fdawgs nice one! LGTM

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would recommend dropping package-lock.json.

As for the why: sindresorhus/ama#479.

@Fdawgs Fdawgs requested a review from mcollina January 18, 2021 16:06
@Fdawgs
Copy link
Member Author

Fdawgs commented Jan 18, 2021

I would recommend dropping package-lock.json.

As for the why: sindresorhus/ama#479.

Thanks @mcollina, I hadn't see this! I've removed the package-lock.json file and reverted back to npm install in the ci.yml

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@aboutlo aboutlo merged commit 67bee1d into fastify:master Jan 21, 2021
@Fdawgs Fdawgs deleted the ci/rebuild branch January 21, 2021 21:00
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants