Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make only() work correctly with required properties #90

Merged
merged 1 commit into from
Dec 23, 2020
Merged

Make only() work correctly with required properties #90

merged 1 commit into from
Dec 23, 2020

Conversation

AjaiKN
Copy link
Contributor

@AjaiKN AjaiKN commented Dec 22, 2020

Previously, if an object's properties were restricted with .only([...]), props that were removed were still required. (See the test I added for an example that was previously failing.)

Checklist

@AjaiKN
Make only() work correctly with required props
802b5dc 
Previously, if an objects properties were restricted with only(), props that were removed would still be required.
mcollina
mcollina approved these changes Dec 22, 2020
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@aboutlo aboutlo merged commit c3fbd31 into fastify:master Dec 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AjaiKN @mcollina @aboutlo