-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix wrong jsdoc links #68
Conversation
@mcollina I've noticed that the links are still broken as we are pointing to https://json-schema.org/latest/json-schema-validation.html which redirects to https://json-schema.org/draft/2019-09/json-schema-validation.html, making all the hash tags to be lost (#xxxxx). Can I change all the links to https://json-schema.org/draft/2019-09/json-schema-validation.html? |
ok for me |
No, that version is not supported: it is draft 08 and we (like ajv) support draft 07! I didn't find the right link, it should be hidden here https://json-schema.org/specification-links.html#draft-7 |
@satazor this is the draft7 reference page https://tools.ietf.org/id/draft-handrews-json-schema-validation-02.html (not nice URL). However, you can use as base URL. |
@aboutlo It seems we are using 01: https://tools.ietf.org/html/draft-handrews-json-schema-01 For instance, in Array schema, Can I update to use https://tools.ietf.org/html/draft-handrews-json-schema-01? |
nice catch @satazor, then yes it's |
d3247cc
to
fae8f7f
Compare
This should be ready to be merged.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks for all the work!
@mcollina no problem, and thank you and the team for this lib! |
Fixes #67
Checklist
npm run test
andnpm run benchmark