Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tests): replaced jest with node:test #245

Merged
merged 2 commits into from
Jun 6, 2024

Conversation

floridemai
Copy link
Contributor

Closes #243

Updated all test files to work with node:test runner. Everything went smooth with only two notes: certain expected objects needed and addiional $id: undefined property and a test where the error type was invalid.

Checklist

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@simoneb
Copy link
Contributor

simoneb commented Jun 6, 2024

@mcollina build is failing on Node 16, I suspect something incompatible with c8 or even node:test. Are we supposed to still support Node 16 with this library?

Copy link
Member

@gurgunday gurgunday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please target next and modify this line to test only on 18, 20, 22:

node-versions: '["16", "18", "20", "22"]'

@floridemai floridemai force-pushed the 243-migrate-tests-to-node-test branch from 595b4b5 to 0bac57b Compare June 6, 2024 13:38
@aboutlo
Copy link
Collaborator

aboutlo commented Jun 6, 2024

Thank you for this @floridemai 🙌

@mcollina
Copy link
Member

mcollina commented Jun 6, 2024

We can just drop node.js v16

Copy link
Member

@gurgunday gurgunday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gurgunday
Copy link
Member

gurgunday commented Jun 6, 2024

We can just drop node.js v16

I think to keep things organized we should keep CI changes in next too, we'll start merging next branches this month or in July anyway for Fastify v5

@gurgunday gurgunday merged commit cb7401e into fastify:next Jun 6, 2024
14 checks passed
@gurgunday
Copy link
Member

Thanks a lot for the PR!

jsumners pushed a commit that referenced this pull request Jun 18, 2024
* chore(tests): replaced jest with node:test

* chore: removed node 16 from version targets
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants