Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use standard and @fastify/pre-commit #190

Merged
merged 6 commits into from
Oct 1, 2022

Conversation

Uzlopak
Copy link
Contributor

@Uzlopak Uzlopak commented Aug 29, 2022

Checklist

@Uzlopak Uzlopak requested a review from aboutlo August 29, 2022 13:22
@coveralls
Copy link

coveralls commented Aug 29, 2022

Pull Request Test Coverage Report for Build 2948849632

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 56 of 56 (100.0%) changed or added relevant lines in 8 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.006%) to 99.853%

Totals Coverage Status
Change from base Build 2926814810: -0.006%
Covered Lines: 401
Relevant Lines: 401

💛 - Coveralls

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm generically -1 in changing the formatting of some code.

@aboutlo
Copy link
Collaborator

aboutlo commented Aug 30, 2022

I have no strong opinion but it's just cosmetic :)

@Uzlopak
Copy link
Contributor Author

Uzlopak commented Aug 30, 2022

@aboutlo
It would be then in line with all the other repos.

Copy link
Member

@Eomm Eomm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm +1 to ease the maintenance across repos by adopting the same structure.

We are free to experiment on personal repos tho

@Uzlopak
Copy link
Contributor Author

Uzlopak commented Sep 20, 2022

Thx @Eomm

But should we merge it or not. @aboutlo i assume you have the golden ticket regarding the vote of @mcollina
Can you approve or close this PR please?

@Eomm Eomm requested a review from mcollina September 21, 2022 05:58
@aboutlo
Copy link
Collaborator

aboutlo commented Oct 1, 2022

no strong opinion, but given others signalled in favor and we can standardise towards what other repo do I will merge it

@aboutlo aboutlo merged commit f62a218 into fastify:master Oct 1, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants