Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: raw key Typescript return type #139

Merged
merged 1 commit into from
Jul 6, 2021

Conversation

joaopedrocampos
Copy link
Contributor

Fixes the raw return on Typescript types

Checklist

  • run npm run test and npm run benchmark
  • tests and/or benchmarks are included (not sure if the index.ts is considered a benchmark)
  • documentation is changed or added
  • commit message and code follows the Developer's Certification of Origin
    and the Code of conduct

Related issue: #129

@joaopedrocampos
Copy link
Contributor Author

@aboutlo I added a new schema on the type's index.ts, but not sure if it's needed and if I used it correctly, what I tried to do was basically add a new "test" to show that the required key is valid independent of it's position

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1001180339

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.559%

Totals Coverage Status
Change from base Build 994617246: 0%
Covered Lines: 410
Relevant Lines: 410

💛 - Coveralls

@aboutlo aboutlo merged commit 68e7d7e into fastify:master Jul 6, 2021
@joaopedrocampos joaopedrocampos deleted the required-json-schema branch July 6, 2021 17:52
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants