Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: test on alternative operating systems; ignore doc updates #127

Merged
merged 2 commits into from
May 13, 2021
Merged

ci: test on alternative operating systems; ignore doc updates #127

merged 2 commits into from
May 13, 2021

Conversation

Fdawgs
Copy link
Member

@Fdawgs Fdawgs commented May 13, 2021

  • Stops CI from running of documentation is updated (waste of a run)
  • Tests on macOS and Windows alongside Ubuntu, to ensure fluent-json-schema runs on all operating systems (Windows is the big one to test, just due to how it handles forward/back slashes differently, and single quotation marks from unix)

Checklist

@coveralls
Copy link

coveralls commented May 13, 2021

Pull Request Test Coverage Report for Build 839090865

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.554%

Totals Coverage Status
Change from base Build 834338069: 0.0%
Covered Lines: 408
Relevant Lines: 408

💛 - Coveralls

@aboutlo
Copy link
Collaborator

aboutlo commented May 13, 2021

LGTM

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 74aa4e1 into fastify:master May 13, 2021
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants