Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop support for EOL Nodejs versions #123

Merged
merged 2 commits into from
May 8, 2021
Merged

Drop support for EOL Nodejs versions #123

merged 2 commits into from
May 8, 2021

Conversation

Fdawgs
Copy link
Member

@Fdawgs Fdawgs commented Apr 29, 2021 •
edited
Loading

  • Drops support for Nodejs v8 (EOL 2019-12-31)
  • Drops support for Nodejs v10 (EOL 2021-04-30)
  • Updated the Dependabot interval from monthly to daily to be the same as other Fastify repos

Checklist

@coveralls
Copy link

coveralls commented Apr 29, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 795843099

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.554%
Totals Coverage Status
Change from base Build 795721321: 0.0%
Covered Lines: 408
Relevant Lines: 408
💛 - Coveralls

mcollina
mcollina approved these changes Apr 29, 2021
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina
Copy link
Member

We should drop Node 8, not pin jest.

@Fdawgs
Copy link
Member Author

Fdawgs commented Apr 29, 2021

We should drop Node 8, not pin jest.

Cool! Will update this PR.
Should Node 10 be dropped as well with it being EOL tomorrow?

@mcollina
Copy link
Member

Yes I would recommend doing that and release a semver-major change @aboutlo.

Frazer Smith added 2 commits April 29, 2021 12:16
build(dependabot): use same interval as other fastify repos
0a9cc26
chore!: drop support for nodejs v8 and v10
db17cdd 
BREAKING CHANGE: support dropped for nodejs v8 (EOL 2019-12-31) and v10 (EOL 2021-04-30)
@Fdawgs Fdawgs changed the title Update dependencies Drop support for EOL Nodejs versions Apr 29, 2021
@Fdawgs Fdawgs requested a review from mcollina April 29, 2021 11:20
mcollina
mcollina approved these changes Apr 29, 2021
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@aboutlo aboutlo merged commit eceb3b7 into fastify:master May 8, 2021
@Fdawgs Fdawgs deleted the build/deps branch May 8, 2021 13:17
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Fdawgs @coveralls @mcollina @aboutlo