Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Resume connection before continuing. [#77] #78

Merged
merged 3 commits into from
Oct 1, 2020
Merged

fix: Resume connection before continuing. [#77] #78

merged 3 commits into from
Oct 1, 2020

Conversation

ShogunPanda
Copy link
Contributor

@ShogunPanda ShogunPanda commented Sep 30, 2020 •
edited
Loading

This fixes #77 by resuming the connection before calling the handler.

Checklist

@mcollina
Copy link
Member

Can you please add a unit test?

@ShogunPanda
Copy link
Contributor Author

Sure. Will do soon!

jsumners
jsumners reviewed Sep 30, 2020
View reviewed changes
index.js Outdated Show resolved Hide resolved
mcollina
mcollina requested changes Oct 1, 2020
View reviewed changes
index.js Outdated Show resolved Hide resolved
@ShogunPanda ShogunPanda closed this Oct 1, 2020
@ShogunPanda ShogunPanda reopened this Oct 1, 2020
mcollina
mcollina approved these changes Oct 1, 2020
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

jsumners
jsumners approved these changes Oct 1, 2020
View reviewed changes
Copy link
Member

@jsumners jsumners left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcollina mcollina merged commit 1335ffe into fastify:master Oct 1, 2020
@mcollina mcollina mentioned this pull request Oct 7, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@jsumners jsumners jsumners approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Socket stops accepting messages
3 participants
@ShogunPanda @mcollina @jsumners