Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve type declaration for errors #147

Merged
merged 6 commits into from
Oct 17, 2023
Merged

Conversation

arthurfiorette
Copy link
Contributor

@arthurfiorette arthurfiorette commented Oct 11, 2023

This PR extends #146, as I would like to merge this as quickly as possible, I also added requested type tests and jsdoc.

This also adds exports to 3 types inside lib/httpError: HttpErrorCodes, HttpErrorNames and HttpErrors.

Thanks :)

Checklist

@arthurfiorette arthurfiorette changed the title Improve type declaration for errors feat: improve type declaration for errors Oct 11, 2023
Copy link
Member

@gurgunday gurgunday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@arthurfiorette
Copy link
Contributor Author

Hey @gurgunday, is there anything else needed to merge this PR?

@gurgunday
Copy link
Member

I restrain from merging type PRs without 2 approvals 😁

I’ll request another review

@gurgunday gurgunday requested review from Eomm and Fdawgs October 14, 2023 20:02
Copy link
Member

@Fdawgs Fdawgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.

Can you please rewrite the JSDoc description to not use 'you'?
See our style guide here. :)

@arthurfiorette
Copy link
Contributor Author

@Fdawgs done! I also updated examples regarding schema id to use camel case HttpError type, which is the usual standard.

Signed-off-by: Arthur Fiorette <47537704+arthurfiorette@users.noreply.github.com>
@Fdawgs Fdawgs requested a review from a team October 16, 2023 15:20
@mcollina
Copy link
Member

Code still LGTM @Fdawgs are you ok with the change?

@mcollina mcollina merged commit 862cd28 into fastify:master Oct 17, 2023
15 checks passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants