Fix typings for http methods shortcuts on fastify reply #134
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix typings for HTTP methods shortcuts added on the
FastifyReply
object.Those signatures were indicating a
void
return while the implementations were returning the reply itself.fixes #133).
I've only updated the typings tests accordingly because the implementation tests were already ensuring that those shortcuts were returning the fastify reply object.
Also note that I've moved the following type from
httpError.d.ts
toindex.d.ts
The reason is that I think the
lib
folder may not contain code related tofastify
itself. It made more sense to me to put that type as close as possible to the concernedFastifyReply
interface.Checklist
npm run test
andnpm run benchmark
(there is no benchmark script)and the Code of conduct