set sameSite: lax by default #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The link to chrome blog is not working. @Uzlopak @gurgunday what do you think the semversiness of this is? I'd err towards semver-major. |
Fixed |
|
After a skim through the article, I think this is semver-major. |
jsumners
pushed a commit
that referenced
this pull request
Jul 3, 2024
jsumners
added a commit
that referenced
this pull request
Jul 3, 2024
* set sameSite: lax by default (#277) * update for Fastify v5 (#276) * update for v5 * Update .github/workflows/ci.yml Co-authored-by: Frazer Smith <frazer.dev@outlook.com> Signed-off-by: Gürgün Dayıoğlu <gurgun.dayioglu@icloud.com> * Revert "Update .github/workflows/ci.yml" This reverts commit b7a3800. * use replaceAll * Revert "use replaceAll" This reverts commit c691788. --------- Signed-off-by: Gürgün Dayıoğlu <gurgun.dayioglu@icloud.com> Co-authored-by: Frazer Smith <frazer.dev@outlook.com> * set sameSite: lax by default (#277) * update for Fastify v5 (#276) * update for v5 * Update .github/workflows/ci.yml Co-authored-by: Frazer Smith <frazer.dev@outlook.com> Signed-off-by: Gürgün Dayıoğlu <gurgun.dayioglu@icloud.com> * Revert "Update .github/workflows/ci.yml" This reverts commit b7a3800. * use replaceAll * Revert "use replaceAll" This reverts commit c691788. --------- Signed-off-by: Gürgün Dayıoğlu <gurgun.dayioglu@icloud.com> Co-authored-by: Frazer Smith <frazer.dev@outlook.com> * update fastify deps * Update .github/workflows/ci.yml Co-authored-by: Gürgün Dayıoğlu <gurgun.dayioglu@icloud.com> Signed-off-by: Matteo Collina <matteo.collina@gmail.com> --------- Signed-off-by: Gürgün Dayıoğlu <gurgun.dayioglu@icloud.com> Signed-off-by: Matteo Collina <matteo.collina@gmail.com> Co-authored-by: Gürgün Dayıoğlu <gurgun.dayioglu@icloud.com> Co-authored-by: Frazer Smith <frazer.dev@outlook.com> Co-authored-by: Matteo Collina <hello@matteocollina.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #268
There isn't a connection between
secureandsameSite, so it doesn't make sense to override the user's setting if the connection is insecureHowever, having
'lax'as the default option is useful since even though the absence of sameSite is interpreted as 'lax' by modern browsers, some user agents might not behave this wayRef: https://web.dev/articles/samesite-cookies-explained#changes_to_the_default_behavior_without_samesite