chore: remove getPackageType deps, fix for Bun
#335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcollina
reviewed
Oct 18, 2023
Fdawgs
requested changes
Oct 18, 2023
bodinsamuel
pushed a commit
to specfy/specfy
that referenced
this pull request
Nov 22, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@fastify/autoload](https://togithub.com/fastify/fastify-autoload) | [`5.7.1` -> `5.8.0`](https://renovatebot.com/diffs/npm/@fastify%2fautoload/5.7.1/5.8.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>fastify/fastify-autoload (@​fastify/autoload)</summary> ### [`v5.8.0`](https://togithub.com/fastify/fastify-autoload/releases/tag/v5.8.0) [Compare Source](https://togithub.com/fastify/fastify-autoload/compare/v5.7.2...v5.8.0) **Full Changelog**: fastify/fastify-autoload@v5.7.2...v5.8.0 ### [`v5.7.2`](https://togithub.com/fastify/fastify-autoload/releases/tag/v5.7.2) [Compare Source](https://togithub.com/fastify/fastify-autoload/compare/v5.7.1...v5.7.2) #### What's Changed - chore(deps-dev): bump esbuild from 0.16.17 to 0.17.0 by [@​dependabot](https://togithub.com/dependabot) in [fastify/fastify-autoload#294 - chore(deps-dev): bump vitest from 0.26.3 to 0.27.1 by [@​dependabot](https://togithub.com/dependabot) in [fastify/fastify-autoload#295 - chore(deps-dev): bump vitest from 0.27.3 to 0.28.3 by [@​dependabot](https://togithub.com/dependabot) in [fastify/fastify-autoload#299 - chore(deps-dev): bump vitest from 0.28.5 to 0.29.1 by [@​dependabot](https://togithub.com/dependabot) in [fastify/fastify-autoload#301 - chore(.gitignore): add bun lockfile by [@​Fdawgs](https://togithub.com/Fdawgs) in [fastify/fastify-autoload#302 - chore(deps-dev): bump tsd from 0.25.0 to 0.28.0 by [@​dependabot](https://togithub.com/dependabot) in [fastify/fastify-autoload#304 - chore(deps-dev): bump typescript from 4.9.5 to 5.0.2 by [@​dependabot](https://togithub.com/dependabot) in [fastify/fastify-autoload#305 - chore(deps-dev): bump vitest from 0.29.8 to 0.30.1 by [@​dependabot](https://togithub.com/dependabot) in [fastify/fastify-autoload#307 - ci: only trigger on pushes to main branches by [@​Fdawgs](https://togithub.com/Fdawgs) in [fastify/fastify-autoload#308 - chore(deps-dev): bump [@​types/node](https://togithub.com/types/node) from 18.16.5 to 20.1.0 by [@​dependabot](https://togithub.com/dependabot) in [fastify/fastify-autoload#310 - chore(deps-dev): bump vitest from 0.30.1 to 0.31.1 by [@​dependabot](https://togithub.com/dependabot) in [fastify/fastify-autoload#312 - chore(deps-dev): bump esbuild from 0.17.19 to 0.18.0 by [@​dependabot](https://togithub.com/dependabot) in [fastify/fastify-autoload#313 - chore(deps-dev): bump vitest from 0.31.4 to 0.32.0 by [@​dependabot](https://togithub.com/dependabot) in [fastify/fastify-autoload#314 - refactor(index): convert unused capture groups to non-capture groups by [@​Fdawgs](https://togithub.com/Fdawgs) in [fastify/fastify-autoload#318 - chore(deps-dev): bump vitest from 0.32.4 to 0.33.0 by [@​dependabot](https://togithub.com/dependabot) in [fastify/fastify-autoload#319 - chore(deps-dev): bump vitest from 0.33.0 to 0.34.1 by [@​dependabot](https://togithub.com/dependabot) in [fastify/fastify-autoload#321 - chore(deps-dev): bump esbuild from 0.18.20 to 0.19.2 by [@​dependabot](https://togithub.com/dependabot) in [fastify/fastify-autoload#322 - chore(deps-dev): bump tsd from 0.28.1 to 0.29.0 by [@​dependabot](https://togithub.com/dependabot) in [fastify/fastify-autoload#324 - perf: use `node:` prefix to bypass require.cache call for builtins by [@​Fdawgs](https://togithub.com/Fdawgs) in [fastify/fastify-autoload#325 - feat: add FASTIFY_AUTOLOAD_TYPESCRIPT environment variable by [@​Uzlopak](https://togithub.com/Uzlopak) in [fastify/fastify-autoload#327 - docs(readme): update typescript env variable section by [@​Fdawgs](https://togithub.com/Fdawgs) in [fastify/fastify-autoload#328 - perf(index): convert unused capture group to non-capture group by [@​Fdawgs](https://togithub.com/Fdawgs) in [fastify/fastify-autoload#330 - docs(readme): fix capitalization of typescript by [@​Fdawgs](https://togithub.com/Fdawgs) in [fastify/fastify-autoload#333 - chore: add `.gitattributes` file by [@​Fdawgs](https://togithub.com/Fdawgs) in [fastify/fastify-autoload#334 - test(commonjs): add missing `use strict` directives by [@​Fdawgs](https://togithub.com/Fdawgs) in [fastify/fastify-autoload#336 - chore: remove `getPackageType` deps, fix for Bun by [@​ObscuritySRL](https://togithub.com/ObscuritySRL) in [fastify/fastify-autoload#335 #### New Contributors - [@​ObscuritySRL](https://togithub.com/ObscuritySRL) made their first contribution in [fastify/fastify-autoload#335 **Full Changelog**: fastify/fastify-autoload@v5.7.1...v5.7.2 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 4pm every weekday" in timezone Europe/Paris, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/specfy/specfy). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy41OS44IiwidXBkYXRlZEluVmVyIjoiMzcuNTkuOCIsInRhcmdldEJyYW5jaCI6ImNob3JlL3Jlbm92YXRlQmFzZUJyYW5jaCJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
This was referenced Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
getPackageTypefunction needlessly relied on thepkg-uppackage tree. While unnecessary, it also caused@fastify/autoloadto not work with Bun.Have run
lint:fixandtestwith no issues. All changes are internal and require no documentation changes.Not sure the other requirements for contributing to Fastify.
Checklist
npm run testandnpm run benchmarkand the Code of conduct