Skip to content
This repository has been archived by the owner on Feb 2, 2024. It is now read-only.

fix unit tests, replace pem with self-cert #72

Merged
merged 6 commits into from
Dec 8, 2022
Merged

fix unit tests, replace pem with self-cert #72

merged 6 commits into from
Dec 8, 2022

Conversation

Uzlopak
Copy link
Contributor

@Uzlopak Uzlopak commented Dec 7, 2022

We dont need to make big changes, to get the unit tests running again. Created a RSA private key and just supply it to pem, avoiding to make big refactoring.

Checklist

@Uzlopak Uzlopak requested a review from Eomm December 7, 2022 20:25
@Uzlopak
Copy link
Contributor Author

Uzlopak commented Dec 7, 2022

strange. locally it runs?!

@Uzlopak Uzlopak changed the title fix unit tests, generate private-key.pem fix unit tests, replace pem with selfsigned Dec 7, 2022
@Uzlopak Uzlopak changed the title fix unit tests, replace pem with selfsigned fix unit tests, replace pem with self-cert Dec 7, 2022
@Uzlopak
Copy link
Contributor Author

Uzlopak commented Dec 7, 2022

OK, replaced pem with self-cert. First replaced it with selfsigned, but then I realized that self-cert is made by @jsumners so I use that instead.

@Uzlopak Uzlopak requested a review from jsumners December 7, 2022 21:01
@Uzlopak Uzlopak mentioned this pull request Dec 7, 2022
4 tasks
@jsumners
Copy link
Member

jsumners commented Dec 8, 2022

For what it's worth, I don't care which one is used as long as it works. But I was planning to point out fastify/fastify#3711 as the way to go about it.

Copy link
Member

@jsumners jsumners left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@Uzlopak
Copy link
Contributor Author

Uzlopak commented Dec 8, 2022

Thank you.

@Uzlopak Uzlopak merged commit 6c06756 into master Dec 8, 2022
@Uzlopak Uzlopak deleted the fix-tests branch December 8, 2022 12:54
Copy link
Member

@Eomm Eomm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Top!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants