Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update async extension and add tests #635

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

PookieBuns
Copy link
Contributor

  1. update _init_.py file so import can now be found using from sqlmodel.ext.asyncio import AsyncSession which obeys the import format of sqlalchemy Add documentation about how to use the async tools (session, etc) #626 (comment)
  2. add tests to AsyncSession utilizing testcontainers and asyncpg. This could introduce overhead for further testing because it requures a docker container to be spun up
  3. add a create_async_engine function to match its non async port of create_engine

Doesn't really address the documentation part of #626 but adds a few QOL features and sets up an easy testing framework for async features

@PookieBuns
Copy link
Contributor Author

PookieBuns commented Aug 10, 2023

@tiangolo pypa/setuptools#3452
there is an issue with importlib which is causing mkdocs fail to run because importlib-metadata is lower than 4.3.0. Currently the project has importlib-metadata stuck on 4.2.0 due to the fact that mkdocs must be 1.2.x which is causing some checks to fail randomly. Could we update the mkdocs version?

@tiangolo tiangolo added the feature New feature or request label Oct 22, 2023
@github-actions
Copy link

📝 Docs preview for commit af84d75 at: https://5fc91ef2.sqlmodel.pages.dev

@PookieBuns
Copy link
Contributor Author

@tiangolo I have merged 0.0.9 into the PR branch. All tests pass now :)

Copy link

github-actions bot commented Nov 5, 2023

📝 Docs preview for commit fb60073 at: https://f6ad04c2.sqlmodel.pages.dev

@peidrao
Copy link

peidrao commented Nov 19, 2023

Fix conflicts

Copy link

📝 Docs preview for commit 3e9bfd8 at: https://c7b5a1e8.sqlmodel.pages.dev

@caerulescens caerulescens mentioned this pull request Feb 4, 2024
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants