Support pyright-langserver from python package #1086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `pyright-langserver` provided by the [`pyright` Python package](https://pypi.org/project/pyright/) is a Python script and not a NodeJS script.
fannheyward
approved these changes
Jun 18, 2024
|
But this breaks custom node-based pyright-langserver feature. |
Would you like to keep these features? Do you have some ideas how we can work around this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my project I’m using the
pyrightPython package as a dependency for type checking on CI. I would like to use the same version in my editor, but settingpyright.server: "pyright-langserver"does not work.The
pyright-langserverbinary provided by thepyrightPython package is a Python script and not a NodeJS script.I implemented it so that only a custom pyright-langserver is started as a binary but maybe we also want to start the included server as a binary to make the code simpler.