Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Isometric causing weird issues #72

Open
Steveo5 opened this issue Oct 13, 2016 · 5 comments
Open

Isometric causing weird issues #72

Steveo5 opened this issue Oct 13, 2016 · 5 comments

Comments

@Steveo5
Copy link

Steveo5 commented Oct 13, 2016

Hello, I have everything up and running properly and all works well. However I noticed that when moving the view around the map because its isometric and therefore at a different angle then things that are supposedly outside the view don't get drawn even though they are still visible. How could I fix this? Cheers!

@fallahn
Copy link
Owner

fallahn commented Oct 13, 2016

Probably related to #59 - the first place to look would probably be how the layer patches are generated for isometric maps. The bounding boxes for these patches are used for culling (iirc).

@Steveo5
Copy link
Author

Steveo5 commented Oct 13, 2016

Oh cheers, edited some of the bounding boxes and now all works well!

@fallahn
Copy link
Owner

fallahn commented Oct 13, 2016

Good to know! If it fixes a bug could you perhaps share what you did or submit a pull request?

@Steveo5
Copy link
Author

Steveo5 commented Oct 13, 2016

I just added a padding to the bounding box, for example in the MapLayer.cpp at line 94 I took off a padding of 1000 so that way the map should generate a little outside of the view port area. Possibly could check if the map is isometric first but mine is so I didn't bother.

@fallahn
Copy link
Owner

fallahn commented Oct 14, 2016

It sounds like it could be as simple as correctly converting isometric coords into sfml/world coords. I'll investigate further when I can. Thanks for the feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants