Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new(ci): added an arm64 musl build. #2532

Closed
wants to merge 2 commits into from
Closed

new(ci): added an arm64 musl build. #2532

wants to merge 2 commits into from

Conversation

FedeDP
Copy link
Contributor

@FedeDP FedeDP commented May 4, 2023

What type of PR is this?

/kind feature

Any specific area of the project related to this PR?

/area CI

What this PR does / why we need it:

Since we do provide an x86_64 musl static package, we should also provide an arm64 one.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@poiana poiana requested review from Kaizhe and mstemm May 4, 2023 13:10
@FedeDP
Copy link
Contributor Author

FedeDP commented May 4, 2023

/milestone 0.36.0
We don't need it now; and we don't want to fight again with the CI at this stage.
Postpone to next version.

@poiana poiana added this to the 0.36.0 milestone May 4, 2023
@FedeDP
Copy link
Contributor Author

FedeDP commented May 4, 2023 •
edited

/hold for now.

Moreover, this PR would also requires us to schedule 2 pods on arm64 at the same time on our prow cluster, meaning that we would probably want to enlarge our arm runner replicas: https://github.com/falcosecurity/test-infra/blob/master/config/prow/arc/arm-runner.yaml#L6.
We will eventually get there in the future, but for now we only have 1 arm64 node.

@FedeDP FedeDP force-pushed the new/static_aarch64 branch 2 times, most recently from 2ec15ad to 3bb6155 Compare May 4, 2023 13:13
jasondellaluce
jasondellaluce previously approved these changes May 5, 2023
View reviewed changes
@poiana poiana added the lgtm label May 5, 2023
leogr
leogr previously approved these changes May 8, 2023
View reviewed changes
@FedeDP FedeDP dismissed stale reviews from leogr and jasondellaluce via 5556492 May 10, 2023 10:54
@FedeDP
Copy link
Contributor Author

FedeDP commented May 10, 2023

Rebased on top of master ;)

jasondellaluce
jasondellaluce previously approved these changes May 10, 2023
View reviewed changes
Andreagit97
Andreagit97 previously approved these changes May 10, 2023
View reviewed changes
Copy link
Member

@Andreagit97 Andreagit97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@FedeDP FedeDP mentioned this pull request Jun 13, 2023
Merged
@FedeDP FedeDP dismissed stale reviews from Andreagit97 and jasondellaluce via 540dee4 June 29, 2023 08:22
@jasondellaluce
Copy link
Contributor

I think reusable_test_packages.yml should be updated as well to avoid skipping static build tests for arm64!

@FedeDP FedeDP mentioned this pull request Jun 29, 2023
Merged
@FedeDP
Copy link
Contributor Author

FedeDP commented Aug 29, 2023

/milestone 0.37.0

No time for this during this release cycle; this is not that important after all, we can live without it for another release cycle.

@poiana poiana modified the milestones: 0.36.0, 0.37.0 Aug 29, 2023
@Andreagit97 Andreagit97 modified the milestones: 0.37.0, TBD Aug 31, 2023
@FedeDP
Copy link
Contributor Author

FedeDP commented Oct 17, 2023

Rebased on top of master. Still waiting to get more self-hosted runners on test-infra cluster.

leogr
leogr previously approved these changes Nov 9, 2023
View reviewed changes
incertum
incertum previously approved these changes Nov 18, 2023
View reviewed changes
Copy link
Contributor

@incertum incertum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

/hold

@FedeDP please unhold when you feel it should be merged.

@FedeDP FedeDP mentioned this pull request Dec 6, 2023
Merged
@FedeDP
new(ci): added an arm64 musl build.
d978f0c 
Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
@FedeDP
new(ci): run driver loader tests on arm64 too.
a669f40 
Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
@FedeDP FedeDP dismissed stale reviews from incertum and leogr via a669f40 December 11, 2023 08:56
@poiana
Copy link

poiana commented Dec 11, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, FedeDP, incertum

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Andreagit97,FedeDP,incertum]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@poiana
Copy link

poiana commented Dec 11, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, FedeDP, incertum

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Andreagit97,FedeDP,incertum]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@FedeDP
Copy link
Contributor Author

FedeDP commented Dec 11, 2023

/cc @LucaGuerra PTAL :)

@poiana poiana added size/M and removed size/S labels Dec 11, 2023
@FedeDP
Copy link
Contributor Author

FedeDP commented Dec 11, 2023

@Andreagit97 i enabled back driver loader tests on arm64 too, now! Since we now have actuated arm64 node that runs ubuntu, we should be able to run them!

@FedeDP
Copy link
Contributor Author

FedeDP commented Dec 11, 2023 •
edited

Error: JavaScript Actions in Alpine containers are only supported on x64 Linux runners. Detected Linux Arm64

Oh wow.
Feature request: actions/runner#801
It seems like we are out of luck for now.

@FedeDP
Copy link
Contributor Author

FedeDP commented Dec 11, 2023

I will close this one since it cannot be supported right now; and open a new PR with only the driver-loader enablement for arm64 part.

@FedeDP
Copy link
Contributor Author

FedeDP commented Dec 11, 2023

/close

@poiana poiana closed this Dec 11, 2023
@poiana
Copy link

poiana commented Dec 11, 2023

@FedeDP: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leogr leogr leogr left review comments

@jasondellaluce jasondellaluce jasondellaluce left review comments

@incertum incertum incertum left review comments

@Andreagit97 Andreagit97 Andreagit97 left review comments

@Kaizhe Kaizhe Awaiting requested review from Kaizhe

@mstemm mstemm Awaiting requested review from mstemm

Assignees

@leogr leogr

@jasondellaluce jasondellaluce

@incertum incertum

@Andreagit97 Andreagit97

Labels
approved area/ci dco-signoff: yes do-not-merge/hold kind/feature lgtm release-note-none size/M
Projects
None yet
Milestone
TBD
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@FedeDP @jasondellaluce @poiana @leogr @incertum @Andreagit97