Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Bank and Sport to Swedish locale #2961

Merged
merged 2 commits into from
May 31, 2024

Conversation

twk-mn
Copy link
Contributor

@twk-mn twk-mn commented May 31, 2024

Motivation / Background

This Pull Request has been created because I added Swedish translations for the following:

  • Banks
  • Sports

Additional information

  • I looked up which banks are the most commonly used in Sweden (focused on the ones that were consumer banks).
  • I went with the sports that are currently listed on the Swedish Olympic Committee, and the Swedish Parasport Federation's website.
  • I am a Swedish native speaker, and made sure to spell check the additions.

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one change. Changes that are unrelated should be opened in separate PRs.
  • Commit message has a detailed description of what changed and why. If this PR fixes a related issue include it in the commit message. Ex: [Fix #issue-number]
  • Tests are added or updated if you fix a bug, refactor something, or add a feature.
  • Tests and Rubocop are passing before submitting your proposed changes.

If you're proposing a new generator or locale:

  • Double-check the existing generators documentation to make sure the new generator you want to add doesn't already exist.
  • You've reviewed and followed the Contributing guidelines.

@psibi psibi merged commit 938485f into faker-ruby:main May 31, 2024
8 checks passed
@psibi
Copy link
Member

psibi commented May 31, 2024

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants