Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "added travel folder and airports" #2628

Merged
merged 1 commit into from
Nov 19, 2022
Merged

Revert "added travel folder and airports" #2628

merged 1 commit into from
Nov 19, 2022

Conversation

stefannibrasil
Copy link
Contributor

Reverts #2601

Why

We missed an important part: Faker no longer support positional arguments. During code review, we didn't catch this generator was using positional arguments instead of keywords arguments.

Reverting this PR so @ZionMiller can change it to use positional arguments, and update the docs as necessary.

@thdaraujo thdaraujo merged commit 0ebdde5 into main Nov 19, 2022
@ZionMiller
Copy link
Contributor

Missed that too, thanks for catching it! Just made the changes 🤝

@stefannibrasil
Copy link
Contributor Author

Missed that too, thanks for catching it! Just made the changes handshake

Yay! Could you open a new PR for it? I will approve when it's ready. I think it's easier to keep the git history if we create a new PR. Thank you 👐

@ZionMiller
Copy link
Contributor

Missed that too, thanks for catching it! Just made the changes handshake

Yay! Could you open a new PR for it? I will approve when it's ready. I think it's easier to keep the git history if we create a new PR. Thank you 👐

Sounds good. I'm a little unclear on revert best practice. Should I reclone and move my files over to a fresh PR, or find a way to revert this merge?

@stefannibrasil
Copy link
Contributor Author

I think opening a new PR mentioning this revert would be a good approach. It will preserve the git history.

@stefannibrasil stefannibrasil deleted the revert-2601-main branch November 22, 2022 17:38
@ZionMiller ZionMiller mentioned this pull request Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants