Spongebob TV show collections #2619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thdaraujo
requested changes
Nov 11, 2022
|
@thdaraujo I addressed the comments and reran tests & linting locally. Should be good to go! On a side note, I've seen your name on the patch.io repo quite a bit from the early days. Nice to finally meet you! |
nice to meet you too, James! Hope my code didn't cause you too much trouble 😆 |
|
@thdaraujo heads up that this change didn't make it in the 3.0.0 release but the readme on main has the docs
|
|
hey @kleinjm that's expected. We merged your changes after the v3 release, but it will be included in the next one. 😊 Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds Spongebob TV show collections of characters, quotes, and episodes