Remove support for positional arguments (deprecated on v2)

[mauromorales]

Summary

This PR removes the deprecation warnings added on #1698 plus any newer ones that were added after that.

Fixes #2573

[stefannibrasil]

hi @mauromorales thank you for your contribution! Could you mind pushing an empty commit to trigger the CI? For some reason, your commit didn't trigger any actions.

[stefannibrasil]

Looking good! I am not sure why the CI didn't run, but could you try pushing an empty commit to attempt that? Thanks!

[mauromorales]

@stefannibrasil did an empty commit, but it didn't trigger the pipeline either, maybe related to project config?

Wanted to try to see if adding pull_request_target on the workflow would help, but it needs to be reviewed, can you have a look? And of course feel free to remove the commit if it doesn't help

[Zeragamba]

sometimes it needs someone to approve and run the pipeline. Let me get that going for ya

[mauromorales]

awesome thanks! yup that seems to have triggered it :)

[stefannibrasil]

thanks @Zeragamba I think it was because we needed to point the CI to main instead of master. It looks good now, so feel free to revert the latest two commits @mauromorales thanks!

[mauromorales]

@stefannibrasil dropped the last two commits but doesn't seem to be picked 🧐

[stefannibrasil]

could you fetching your upstream branch and rebasing your branch? This commit should fix that 0581eff

[thdaraujo]

LGTM, thanks for working on this! @mauromorales

Should we bump the major version as well? I'd say yes because this PR introduces breaking changes (see item 8).

We can bump the version in a different PR though.

[thdaraujo]

Well, it looks like v2.0 added the breaking changes. Then v2.2.0 restored the positional arguments but added the deprecation warnings. And now we would be back to removing the functionality. 🤷‍♂️

So not sure if we should bump the major version or not. What are your thoughts @stefannibrasil @Zeragamba ?

[Zeragamba]

I'd call this a breaking change, and thus a v3.0 release. And since v2 was very vocal about not using positional arugments and letting people know they were deprecated, we shouldn't have to add them back in like in v2.2

[stefannibrasil]

@vbrazo we need another release 👀

[koic]

I agree with @Zeragamba. A release containing this breaking change would mean Faker 3.0.
#1692 (comment)