Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add country code for en-CA phone numbers #2561

Merged
merged 1 commit into from
Sep 13, 2022
Merged

Add country code for en-CA phone numbers #2561

merged 1 commit into from
Sep 13, 2022

Conversation

wjessop
Copy link
Contributor

@wjessop wjessop commented Sep 13, 2022

Summary

The phone country_code for Canada is 1, this change mirrors the yaml format of the en-US locale.

thdaraujo
thdaraujo approved these changes Sep 13, 2022
View reviewed changes
Copy link
Contributor

@thdaraujo thdaraujo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense to me! Thank you! ♥

@thdaraujo thdaraujo merged commit 7507876 into faker-ruby:master Sep 13, 2022
@thdaraujo thdaraujo changed the title Return the country code for CA phones numbers Add country code for en-CA phones numbers Sep 13, 2022
@thdaraujo thdaraujo changed the title Add country code for en-CA phones numbers Add country code for en-CA phone numbers Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thdaraujo thdaraujo thdaraujo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wjessop @thdaraujo