Update regex used for Faker::Vehicle#vin #2475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Old regex generated I, O and Q characters inside string, which creates an invalid vin.
|
Can you please link this PR to issue? Also please add test cases for new changes. Thanks in advance |
Old regex was skipping the 'R' character when generating vins
Old regex wasn't checking all of the string
|
All done, thank you for the quick review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Faker::Vehicle.vin generates invalid vin
Description:
Closes #2473.
This pull request updates the Regex used by the Faker::Vehicle#vin method.
The old Regex would include the I, O and Q characters, and would generate an invalid vin string.
No additional tests were written as it was a simple one line update and didn't introduce any significant changes.