Add scope to unique #2471
Closed
Add scope to unique #2471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saiqulhaq
reviewed
Jul 3, 2022
| # @return [self] | ||
| def unique(max_retries = 10_000) | ||
| @unique ||= UniqueGenerator.new(self, max_retries) | ||
| def unique(max_retries = 10_000, scope: DefaultUniqueScope) |
There was a problem hiding this comment.
scope can be just be a string or symbol. If desired a Faker::DEFAULT_UNIQUE_SCOPE contant could be set instead.
Zeragamba
suggested changes
Aug 8, 2022
| # @return [self] | ||
| def unique(max_retries = 10_000) | ||
| @unique ||= UniqueGenerator.new(self, max_retries) | ||
| def unique(max_retries = 10_000, scope: DefaultUniqueScope) |
There was a problem hiding this comment.
scope can be just be a string or symbol. If desired a Faker::DEFAULT_UNIQUE_SCOPE contant could be set instead.
|
Heyo @bradleesand, are you still interested in working on this PR? Thanks! |
|
Closing PR for now due to being almost a month stale. Feel free to comment if you're still planing on working on this and we'll reopen it. |
|
I'm no longer working in Ruby on the daily but I'd be happy to finish it up because this change was really useful to me in my old job. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue#
No-StoryDescription:
Adds an optional
scopeparameter to theuniquemethod. This can be useful if you are using the same generator for multiple unique scope and don't want to run out of unique values. (Like, if you're using Pokemon names in every factory and running out of names.)