Add Faker::Computer #1948
Merged
Add Faker::Computer #1948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
February 17, 2020 23:15
lib/locales/en/computer.yml
Outdated
| - openSUSE Leap 15.1 | ||
| - Ubuntu Desktop 18.04 | ||
| - Ubuntu Desktop 19.10 | ||
| os_x: |
There was a problem hiding this comment.
Perhaps this should be named macOS like the value on platform?
lib/faker/default/computer.rb
Outdated
| # | ||
| # @faker.version next | ||
| def search_format(key) | ||
| key.split.length > 1 ? key.split.join('_').downcase : key.downcase |
There was a problem hiding this comment.
I believe the .split.join is no longer required since the OS X is not present anymore
There was a problem hiding this comment.
Removed code to handle platforms with spaces
lucasqueiroz
approved these changes
Apr 17, 2020
Zeragamba
approved these changes
May 17, 2020
|
@Zeragamba If a PR contains work-in-progress commits, could you like to merge it into master branch by either:
First of all, thank you for your OSS activities 😃 |
koic
added a commit
to koic/faker
that referenced
this pull request
May 17, 2020
Follow up to faker-ruby#1948. This PR fixes the following error for `Faker::Computer.os`. ```console % cd path/to/faker-ruby/faker % bundle exec ruby -Itest test/test_determinism.rb Loaded suite test/test_determinism (snip) test/test_determinism.rb:13:in `test_determinism' test/test_determinism.rb:13:in `each_index' 11: def test_determinism 12: Faker::Config.random = Random.new(42) 13: @all_methods.each_index do |index| => 14: store_result @all_methods[index] 15: end 16: 17: @first_run.freeze test/test_determinism.rb:14:in `block in test_determinism' test/test_determinism.rb:34:in `store_result' test/test_determinism.rb:37:in `rescue in store_result' Error: test_determinism(TestDeterminism): RuntimeError: Faker::Computer.os raised "missing keyword: :platform" ```
koic
added a commit
to koic/faker
that referenced
this pull request
May 17, 2020
Follow up to faker-ruby#1948. This PR fixes the following error for `Faker::Computer.os`. ```console % cd path/to/faker-ruby/faker % bundle exec ruby -Itest test/test_determinism.rb Loaded suite test/test_determinism (snip) test/test_determinism.rb:13:in `test_determinism' test/test_determinism.rb:13:in `each_index' 11: def test_determinism 12: Faker::Config.random = Random.new(42) 13: @all_methods.each_index do |index| => 14: store_result @all_methods[index] 15: end 16: 17: @first_run.freeze test/test_determinism.rb:14:in `block in test_determinism' test/test_determinism.rb:34:in `store_result' test/test_determinism.rb:37:in `rescue in store_result' Error: test_determinism(TestDeterminism): RuntimeError: Faker::Computer.os raised "missing keyword: :platform" ```
|
@koic will do :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue# none
No-StoryDescription:
Faker to generate data for computer types, platforms and OS. Used to populate host data.
Note:
All spec tests failed until
test_helper.rb:changed to
require_relative 'support/assert_not_english'