Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fr locale: pokemon's root key should be games #1903

Merged
merged 1 commit into from
Jan 13, 2020

Conversation

psibi
Copy link
Member

@psibi psibi commented Jan 12, 2020

This also makes it consistent with other locales. Eg: fr-CH, en etc. locale.

This also makes it consistent with other locales. Eg: fr-CH, en etc. locale.
Copy link
Member

@vbrazo vbrazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing all these minor issues that are pretty hard to track 👍

@vbrazo vbrazo merged commit 81bc5a0 into faker-ruby:master Jan 13, 2020
michebble pushed a commit to michebble/faker that referenced this pull request Feb 16, 2020
This also makes it consistent with other locales. Eg: fr-CH, en etc. locale.
davidmorton0 pushed a commit to davidmorton0/faker that referenced this pull request Jul 12, 2021
This also makes it consistent with other locales. Eg: fr-CH, en etc. locale.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants