Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX internet custom domain with suffix #1846

Merged
merged 1 commit into from
Dec 3, 2019
Merged

FIX internet custom domain with suffix #1846

merged 1 commit into from
Dec 3, 2019

Conversation

ngouy
Copy link
Contributor

@ngouy ngouy commented Dec 2, 2019 •
edited
Loading

Issue#

#1845

Description:

Allow custom "full domain" (domains with suffixes and / or subdomain) to be preserved as is

There are many ways to do it (for exemple this works too) :

given_domain_word = domain&.split('.')&.first || domain_word
given_suffix_word = domain&.include?('.') ? domain.split('.').last : domain_suffix
domain_elements = [Char.prepare(given_domain_word), Char.prepare(given_suffix_word)]
domain_elements.unshift(Char.prepare(given_domain_word)) if subdomain

But the one in PR seems more preservative (and clear, but not sure about this one)

@ngouy ngouy marked this pull request as ready for review December 2, 2019 17:32
@vbrazo
Copy link
Member

vbrazo commented Dec 2, 2019 •
edited
Loading

@tiagofsilva @olleolleolle

olleolleolle
olleolleolle approved these changes Dec 3, 2019
View reviewed changes
Copy link
Contributor

@olleolleolle olleolleolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, this matches what I've expected from the API, and I'm excited about this change.

@vbrazo vbrazo merged commit 9ad0a59 into faker-ruby:master Dec 3, 2019
@tiagofsilva
Copy link
Contributor

Frankly, I think the fix was a bit convoluted. I'll make a refactor suggestion PR later today.

@tiagofsilva tiagofsilva mentioned this pull request Dec 4, 2019
Merged
@ngouy ngouy mentioned this pull request Feb 6, 2020
Closed
michebble pushed a commit to michebble/faker that referenced this pull request Feb 16, 2020
@ngouy @michebble
FIX internet custom domain with suffix (faker-ruby#1846)
452a314
davidmorton0 pushed a commit to davidmorton0/faker that referenced this pull request Jul 12, 2021
@ngouy @vbrazo
FIX internet custom domain with suffix (faker-ruby#1846)
8e987db
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olleolleolle olleolleolle olleolleolle approved these changes

@vbrazo vbrazo vbrazo approved these changes

Assignees

@ngouy ngouy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ngouy @vbrazo @tiagofsilva @olleolleolle