Add Brazilian documents generation and documentation #1495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix Faker::Internet.ip_v4_address to include all IP ranges (#1494)
Add alias for Brazilian ID number
|
I noticed the tests are a bit messy. Maybe it could have a test for the checksum methods so it validates the algorithm and another one for the generator, validating it generates a random value with the correct amount of digits + format |
Merge stympy/faker into lucasqueiroz/faker
|
I have refactored the tests so it doesn't require the checksum calculation inside the generator tests. |
|
Love this. Bumping to see if it can get merged - was going to make a similar change myself. |
vbrazo
force-pushed
the
master
branch
3 times, most recently
from
69291b2
to
5cc660c
Compare
vbrazo
approved these changes
Jul 7, 2019
|
@lucasqueiroz could you fix the merge issues? I'd like to include this PR in version 2. Thanks 👍 |
|
Sure, will take a look at it asap! |
Merge stympy/faker into lucasqueiroz/faker
|
Hi @vbrazo, I have fixed the conflicts and added the RG generator to the ID documentation. Please let me know if there is any change required. Thanks! |
michebble
pushed a commit
to michebble/faker
that referenced
this pull request
Feb 16, 2020
* Change default parameter format in brazilian_citizen_number * Add alias to brazilian_citizen_number * Add Brazilian ID generator * Change generator for Brazilian ID number Add alias for Brazilian ID number * Add docs for Brazilian Citizen Number (CPF) * Add docs for Brazilian ID (RG) * Add tests for brazilian id digit * Remove if statement from brazilian id digit method * Refactor brazilian_document_remainder and rename it to brazilian_document_digit * Add tests for brazilian_citizen_number_digit * Add tests for brazilian_document_digit * Add tests for brazilian_document_checksum * Add tests for brazilian_id_checksum_digit * Add tests for brazilian_citizen_number_checksum_digit * Simplify brazilian document tests * Add Brazilian ID (RG) to ID Number docs * Minor changes * Remove unused file * Minor fixes * Readd docs after deleting unreleased docs folder * docs
davidmorton0
pushed a commit
to davidmorton0/faker
that referenced
this pull request
Jul 12, 2021
* Change default parameter format in brazilian_citizen_number * Add alias to brazilian_citizen_number * Add Brazilian ID generator * Change generator for Brazilian ID number Add alias for Brazilian ID number * Add docs for Brazilian Citizen Number (CPF) * Add docs for Brazilian ID (RG) * Add tests for brazilian id digit * Remove if statement from brazilian id digit method * Refactor brazilian_document_remainder and rename it to brazilian_document_digit * Add tests for brazilian_citizen_number_digit * Add tests for brazilian_document_digit * Add tests for brazilian_document_checksum * Add tests for brazilian_id_checksum_digit * Add tests for brazilian_citizen_number_checksum_digit * Simplify brazilian document tests * Add Brazilian ID (RG) to ID Number docs * Minor changes * Remove unused file * Minor fixes * Readd docs after deleting unreleased docs folder * docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request closes the issue #1208.
For this generation, I used the #1382 checksum generator (I separated it into two methods so it can be reused, added documentation and an alias).
It generates a valid Brazilian ID based on SSP rules.