Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add subscription and payment terms #1437

Closed

Conversation

fabdurso
Copy link
Contributor

No description provided.

Copy link
Member

@vbrazo vbrazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like these methods but I don't know if they should be located in Faker::Internet. When I see payment_term and subscription_term, the first thing that comes to my mind is subscription business models. They're becoming popular and nowadays most companies are using this revenue strategy.

What do you think about adding Faker::Subscription? It could contain these fields:

  • plan: Gold, Silver and etc
  • status: active, pending and etc
  • payment_method: credit card, debit card and etc
  • subscription_term
  • payment_term

@vbrazo
Copy link
Member

vbrazo commented Oct 23, 2018

@stympy I know that honeybadger.io has a subscription model. What do you think about my suggestion?

@fabdurso
Copy link
Contributor Author

@vbrazo I wasn't totally sure about Faker::Internet, but I decided to add the methods there since they are also related to "internet" subscription models.
Faker::Subscription is certainly a better idea and I will try to work on that. Thanks!

@fabdurso fabdurso closed this Oct 24, 2018
@fabdurso fabdurso deleted the payment_and_subscription_terms branch October 24, 2018 08:39
@fabdurso fabdurso restored the payment_and_subscription_terms branch October 24, 2018 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants