-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bug #25 for GHC 9.4 and text-2 #26
base: master
Are you sure you want to change the base?
Conversation
text-2 switched from UTF-16 to UTF-8, so we need to adjust our pointer logic.
@sternenseemann @tvh we should merge this PR. Who has the rights to do so? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@skogsbaer We depend on the hashes being stable. This would therefore be a breaking change. Do you see a way to still use UTF-16 in the new version? Maybe via Data.Text.Lazy
?
Lazy text also uses UTF-8 internally (it's just a list of strict tests). I don't see a way to retain backwards compatibility without introducing a performance overhead, e.g. by converting UTF-8 to UTF-16 to do the hashing. |
I agree there is no way to avoid that overhead. The reason why I mentioned lazy text is that it would avoid having to have all in memory at the same time. |
A potential fix for the problem is still in discussion: factisresearch/large-hashable#26
A potential fix for the problem is still in discussion: factisresearch/large-hashable#26
A potential fix for the problem is still in discussion: factisresearch/large-hashable#26
A potential fix for the problem is still in discussion: factisresearch/large-hashable#26
No description provided.