Added support for empty messages #960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
please apply the correct formatting using pre-commit |
|
also, are you sure that this is a good idea? how do we distinguish between "zero as null" and actual zeros? |
|
How do I do that? |
|
That actually can't be a thing. A message in zcm is like a c-struct. There are always fields inside the message that have values. The message itself can't have a value. Does that make sense? |
|
@facontidavide done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds support for zcm messages that are empty. Before the messages would just be dropped and not displayed in PlotJuggler. Now they will show up at the correct timestamp with no contents and a numeric value of 0 for each message that exists