Fix infinite streaming buffer regression #953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice, +1 to get this merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that sometime ago #174 got removed. Therefore there's no way to switch off streaming buffer limit, which is not suitable for some cases. Let's say data acquisition rate is 1Hz, then 999 seconds is less than half an hour (basically nothing in terms of long measurements). Was this removal a conscious decision or an accident? This PR reintroduces #174.
I managed to use a combination of CSV import and real-time streaming to plot long live data series, however such a configuration revealed one more issue. Namely, when "quick reload" button is pressed, X axis limits are set according to streaming buffer length, and CSV data length is ignored.
This PR also makes quick reload autoscaling respect static data length.