This repository has been archived by the owner on Mar 19, 2024. It is now read-only.
Add augly transformation support #442
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D31462923 |
iseessel
added a commit
to iseessel/vissl
that referenced
this pull request
Oct 7, 2021
Summary: Pull Request resolved: facebookresearch#442 Add support for augly transformations. Similar to apex, I made augly install optional for users and didn't add it to requirements.txt -- let me know what you think about this. Differential Revision: D31462923 fbshipit-source-id: f21f3399461af1a8e1d48bf360477bf83f81b428
iseessel
force-pushed
the
export-D31462923
branch
from
aea999e
to
0141a00
Compare
|
This pull request was exported from Phabricator. Differential Revision: D31462923 |
facebook-github-bot
added
the
CLA Signed
iseessel
added a commit
to iseessel/vissl
that referenced
this pull request
Oct 7, 2021
Summary: Pull Request resolved: facebookresearch#442 Add support for augly transformations. Similar to apex, I made augly install optional for users and didn't add it to requirements.txt -- let me know what you think about this. Differential Revision: D31462923 fbshipit-source-id: 65bc0cf9c2bbdfe27a51ceb31412a7e35fb22c03
iseessel
force-pushed
the
export-D31462923
branch
from
0141a00
to
b7120e7
Compare
|
This pull request was exported from Phabricator. Differential Revision: D31462923 |
iseessel
added a commit
to iseessel/vissl
that referenced
this pull request
Oct 7, 2021
Summary: Pull Request resolved: facebookresearch#442 Add support for augly transformations. Similar to apex, I made augly install optional for users and didn't add it to requirements.txt -- let me know what you think about this. Reviewed By: QuentinDuval Differential Revision: D31462923 fbshipit-source-id: c5c0adac5b3b1ed30c34b6e9416fc08ea0443686
iseessel
force-pushed
the
export-D31462923
branch
from
b7120e7
to
2d2d5a5
Compare
|
This pull request was exported from Phabricator. Differential Revision: D31462923 |
iseessel
added a commit
to iseessel/vissl
that referenced
this pull request
Oct 7, 2021
Summary: Pull Request resolved: facebookresearch#442 Add support for augly transformations. Similar to apex, I made augly install optional for users and didn't add it to requirements.txt -- let me know what you think about this. Reviewed By: QuentinDuval Differential Revision: D31462923 fbshipit-source-id: 5e4a45a2f2b4711681923c20712694dd676f4eed
iseessel
force-pushed
the
export-D31462923
branch
from
2d2d5a5
to
c335e88
Compare
|
This pull request was exported from Phabricator. Differential Revision: D31462923 |
iseessel
added a commit
to iseessel/vissl
that referenced
this pull request
Oct 7, 2021
Summary: Pull Request resolved: facebookresearch#442 Add support for augly transformations. Similar to apex, I made augly install optional for users and didn't add it to requirements.txt -- let me know what you think about this. Reviewed By: QuentinDuval Differential Revision: D31462923 fbshipit-source-id: 6c4c998384fbad888d2149adf6b13a0651ebf9b6
iseessel
force-pushed
the
export-D31462923
branch
from
c335e88
to
c558678
Compare
|
This pull request was exported from Phabricator. Differential Revision: D31462923 |
iseessel
added a commit
to iseessel/vissl
that referenced
this pull request
Oct 7, 2021
Summary: Pull Request resolved: facebookresearch#442 Add support for augly transformations. Similar to apex, I made augly install optional for users and didn't add it to requirements.txt -- let me know what you think about this. Reviewed By: QuentinDuval Differential Revision: D31462923 fbshipit-source-id: c57f5e75cb8a50e16a718cd8e4bc94f125b23ad1
iseessel
force-pushed
the
export-D31462923
branch
from
c558678
to
e47b923
Compare
|
This pull request was exported from Phabricator. Differential Revision: D31462923 |
iseessel
added a commit
to iseessel/vissl
that referenced
this pull request
Oct 7, 2021
Summary: Pull Request resolved: facebookresearch#442 Add support for augly transformations. Similar to apex, I made augly install optional for users and didn't add it to requirements.txt -- let me know what you think about this. Reviewed By: prigoyal, QuentinDuval Differential Revision: D31462923 fbshipit-source-id: 91405b4ec8194617b5e69346c8939e0adb265c10
iseessel
force-pushed
the
export-D31462923
branch
from
e47b923
to
90e4b9b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D31462923 |
iseessel
added a commit
to iseessel/vissl
that referenced
this pull request
Oct 7, 2021
Summary: Pull Request resolved: facebookresearch#442 Add support for augly transformations. Similar to apex, I made augly install optional for users and didn't add it to requirements.txt -- let me know what you think about this. Reviewed By: prigoyal, QuentinDuval Differential Revision: D31462923 fbshipit-source-id: 7c4bd6a5051d6b0d9af1f50f2820076ceeb2e18f
iseessel
force-pushed
the
export-D31462923
branch
from
90e4b9b
to
eacd0bd
Compare
|
This pull request was exported from Phabricator. Differential Revision: D31462923 |
iseessel
added a commit
to iseessel/vissl
that referenced
this pull request
Oct 7, 2021
Summary: Pull Request resolved: facebookresearch#442 Add support for augly transformations. Similar to apex, I made augly install optional for users and didn't add it to requirements.txt -- let me know what you think about this. Reviewed By: prigoyal, QuentinDuval Differential Revision: D31462923 fbshipit-source-id: 5950a12a563611b7a9ab5e636feea49e3aab3e39
iseessel
force-pushed
the
export-D31462923
branch
from
eacd0bd
to
99d4858
Compare
|
This pull request was exported from Phabricator. Differential Revision: D31462923 |
iseessel
added a commit
to iseessel/vissl
that referenced
this pull request
Oct 7, 2021
Summary: Pull Request resolved: facebookresearch#442 Add support for augly transformations. Similar to apex, I made augly install optional for users and didn't add it to requirements.txt -- let me know what you think about this. Reviewed By: prigoyal, QuentinDuval Differential Revision: D31462923 fbshipit-source-id: 3e5426a0176ae641387b3c3e06673cc9db883a31
iseessel
force-pushed
the
export-D31462923
branch
from
2a6c1d1
to
dcb8742
Compare
iseessel
added a commit
to iseessel/vissl
that referenced
this pull request
Oct 7, 2021
Summary: Pull Request resolved: facebookresearch#442 Add support for augly transformations. Similar to apex, I made augly install optional for users and didn't add it to requirements.txt -- let me know what you think about this. Reviewed By: prigoyal, QuentinDuval Differential Revision: D31462923 fbshipit-source-id: 751d86f17009d60fc50fb644eb6ff29af5aab68a
iseessel
force-pushed
the
export-D31462923
branch
from
dcb8742
to
9110bcf
Compare
|
This pull request was exported from Phabricator. Differential Revision: D31462923 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D31462923 |
prigoyal
reviewed
Oct 8, 2021
.circleci/config.yml
Outdated
| @@ -153,17 +165,18 @@ jobs: | |||
| # Cache the vissl_venv directory that contains dependencies | |||
| - restore_cache: | |||
| keys: | |||
| - v5-cpu-dependencies-{{ checksum "requirements.txt" }}-{{ checksum "setup.py" }} | |||
| - v8-cpu-dependencies-{{ checksum "requirements.txt" }}-{{ checksum "setup.py" }} | |||
There was a problem hiding this comment.
question: why bumping from v5 to v8 directly? why not v6?
There was a problem hiding this comment.
This was result of some testing -- I had to experiment with a lot of different things to make this work -- I'll revert back to v6 here.
tests/test_transforms.py
Outdated
Comment on lines
86
to
93
| def test_augly_transforms(self): | ||
| cfg = compose_hydra_configuration( | ||
| [ | ||
| "config=test/cpu_test/test_cpu_resnet_simclr.yaml", | ||
| "+config/test/cpu_test/transforms=augly_transforms_example", | ||
| ], | ||
| ) | ||
| args, config = convert_to_attrdict(cfg) |
There was a problem hiding this comment.
double check: make sure these tests don't request gpus.
There was a problem hiding this comment.
I'm debugging the ci -- this test doesn't need gpus, but test_tasks.py is picking up the transform config/test/cpu_test/transforms=augly_transforms_example, which is requesting gpus. Solution is to move this dir.
iseessel
added a commit
to iseessel/vissl
that referenced
this pull request
Oct 8, 2021
Summary: Pull Request resolved: facebookresearch#442 Add support for augly transformations. Similar to apex, I made augly install optional for users and didn't add it to requirements.txt -- let me know what you think about this. Reviewed By: prigoyal, QuentinDuval Differential Revision: D31462923 fbshipit-source-id: cae1de39ae456e2441b86a7fab4f644604670e7c
iseessel
force-pushed
the
export-D31462923
branch
from
9110bcf
to
b9688f1
Compare
|
This pull request was exported from Phabricator. Differential Revision: D31462923 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D31462923 |
iseessel
added a commit
to iseessel/vissl
that referenced
this pull request
Oct 8, 2021
Summary: Pull Request resolved: facebookresearch#442 Add support for augly transformations. Similar to apex, I made augly install optional for users and didn't add it to requirements.txt -- let me know what you think about this. Reviewed By: prigoyal, QuentinDuval Differential Revision: D31462923 fbshipit-source-id: 219944e6b12a34fe4ccf510738fba33a7dc3e1f4
iseessel
force-pushed
the
export-D31462923
branch
from
b9688f1
to
a939b71
Compare
iseessel
added a commit
to iseessel/vissl
that referenced
this pull request
Oct 8, 2021
Summary: Pull Request resolved: facebookresearch#442 Add support for augly transformations. Similar to apex, I made augly install optional for users and didn't add it to requirements.txt -- let me know what you think about this. Reviewed By: prigoyal, QuentinDuval Differential Revision: D31462923 fbshipit-source-id: 603d80ec8754957ee7d9eeda890fb637490d8edc
|
This pull request was exported from Phabricator. Differential Revision: D31462923 |
iseessel
force-pushed
the
export-D31462923
branch
from
a939b71
to
e4f603d
Compare
iseessel
added a commit
to iseessel/vissl
that referenced
this pull request
Oct 8, 2021
Summary: Pull Request resolved: facebookresearch#442 Add support for augly transformations. Similar to apex, I made augly install optional for users and didn't add it to requirements.txt -- let me know what you think about this. Reviewed By: prigoyal, QuentinDuval Differential Revision: D31462923 fbshipit-source-id: cb5feef0a5021d62ac5e4a123cd9dfeb02efd0ba
iseessel
force-pushed
the
export-D31462923
branch
from
e4f603d
to
30ba44b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D31462923 |
iseessel
added a commit
to iseessel/vissl
that referenced
this pull request
Oct 8, 2021
Summary: Pull Request resolved: facebookresearch#442 Add support for augly transformations. Similar to apex, I made augly install optional for users and didn't add it to requirements.txt -- let me know what you think about this. Reviewed By: prigoyal, QuentinDuval Differential Revision: D31462923 fbshipit-source-id: a922ae94cc15fa586818d754db31ca2976205b1c
|
This pull request was exported from Phabricator. Differential Revision: D31462923 |
iseessel
force-pushed
the
export-D31462923
branch
from
30ba44b
to
d3b68bf
Compare
iseessel
added a commit
to iseessel/vissl
that referenced
this pull request
Oct 8, 2021
Summary: Pull Request resolved: facebookresearch#442 Add support for augly transformations. Similar to apex, I made augly install optional for users and didn't add it to requirements.txt -- let me know what you think about this. Reviewed By: prigoyal, QuentinDuval Differential Revision: D31462923 fbshipit-source-id: a07f2c7f462028a652a2bdaebcfba077f3bf7b91
iseessel
force-pushed
the
export-D31462923
branch
from
d3b68bf
to
30f4d25
Compare
|
This pull request was exported from Phabricator. Differential Revision: D31462923 |
Summary: Pull Request resolved: facebookresearch#442 Add support for augly transformations. Similar to apex, I made augly install optional for users and didn't add it to requirements.txt -- let me know what you think about this. Reviewed By: prigoyal, QuentinDuval Differential Revision: D31462923 fbshipit-source-id: 258c56bf6c73ff8fa1505dbc6f42188f41d8026b
iseessel
force-pushed
the
export-D31462923
branch
from
30f4d25
to
fe981d5
Compare
|
This pull request was exported from Phabricator. Differential Revision: D31462923 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 8, 2021
Summary: Pull Request resolved: #442 Add support for augly transformations. Similar to apex, I made augly install optional for users and didn't add it to requirements.txt -- let me know what you think about this. Reviewed By: prigoyal, QuentinDuval Differential Revision: D31462923 fbshipit-source-id: ce793f1adc432b3f1ea08acf4b3f66daa88215a8
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differential Revision: D31462923