Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TorchMultimodal][refactor] Support type checking with mypy #22

Closed
wants to merge 2 commits into from

Commits on Apr 8, 2022

  1. [TorchMultimodal][refactor] Support type checking with mypy

    Summary:
    Adding support for type checking using mypy.
    Cleaning up a bunch of files to fix existing type check errors.
    Note that for now we are only type checking non-FLAVA code inside torchmultimodal.
    Also adding some instructions to CONTRIBUTING.md
    
    Test plan:
    ```
    mypy
    Success: no issues found in 28 source files
    ```
    
    ```
    python3 -m pytest -vv
    ...
    42 passed, 2 skipped, 26 warnings in 22.87s
    ```
    
    [ghstack-poisoned]
    ebsmothers committed Apr 8, 2022
    Configuration menu
    Copy the full SHA
    11a1207 View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2022

  1. Update on "[TorchMultimodal][refactor] Support type checking with mypy"

    Summary:
    Adding support for type checking using mypy.
    Cleaning up a bunch of files to fix existing type check errors.
    Note that for now we are only type checking non-FLAVA code inside torchmultimodal.
    Also adding some instructions to CONTRIBUTING.md
    
    Test plan:
    ```
    mypy
    Success: no issues found in 28 source files
    ```
    
    ```
    python3 -m pytest -vv
    ...
    42 passed, 2 skipped, 26 warnings in 22.87s
    ```
    
    [ghstack-poisoned]
    ebsmothers committed Apr 12, 2022
    Configuration menu
    Copy the full SHA
    586e686 View commit details
    Browse the repository at this point in the history