Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extra tasks used in E3B paper #69

Merged
merged 3 commits into from
Jan 4, 2023
Merged

Conversation

mbhenaff
Copy link

This includes:

  • adding N10 versions of MiniGrid envs
  • adding versions with open doors, lava, monsters
  • adding versions of skill-based tasks with restricted action spaces. The original versions with the full action space are marked by X-Full-v0 and the ones with the restricted action spaces are marked with X-Restricted-v0

Mikael Henaff added 2 commits December 15, 2022 07:13
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 15, 2022
@github-actions github-actions bot added the envs Contributions to MiniHack environments label Dec 15, 2022
@mbhenaff mbhenaff changed the title Add task variants used in E3B paper Add extra tasks used in E3B paper Dec 15, 2022
Copy link
Contributor

@samvelyan samvelyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great @mbhenaff. Thanks a lot for your contribution.

Could you please install minihack in dev mode with pre-commit and push another commit? This is to make sure that black and flake8 are applied to the code for consistent style/formatting. If you apply black to any of the submitted python files (e.g. black minihack/envs/skills_wod.py), you'll already have a diff and can try to commit something. Pre-commit will apply formatting for you then. Let me know if you have any questions.

@samvelyan samvelyan merged commit a04b281 into facebookresearch:main Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. envs Contributions to MiniHack environments
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants