Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Bam4d/level editor #46

Merged
merged 11 commits into from
Apr 8, 2022
Merged

Conversation

Bam4d
Copy link
Contributor

@Bam4d Bam4d commented Mar 31, 2022

All Submissions:

IMPORTANT: if this Pull Request concerns an existing issue, please provide the GitHub issue number, otherwise please create an issue first.

Associated issue: #XXXX

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests?
  2. Have you lint your code locally prior to submission?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Closing issues

Put closes #XXXX in your comment to auto-close the issue that your PR fixes (if such).

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 31, 2022
@samvelyan samvelyan self-requested a review April 1, 2022 12:31
Copy link
Member

@samvelyan samvelyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good and works as expected

@samvelyan samvelyan merged commit ec5082d into facebookresearch:main Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants