Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing seeding in MiniGrid #34

Merged
merged 1 commit into from
Nov 22, 2021
Merged

Fixing seeding in MiniGrid #34

merged 1 commit into from
Nov 22, 2021

Conversation

samvelyan
Copy link
Member

Adding seed() method that forwards the random seed to the environment creator for MiniGrid-based environments as well as passes it along to NLE.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 22, 2021
@github-actions github-actions bot added the envs Contributions to MiniHack environments label Nov 22, 2021
mbhenaff
mbhenaff approved these changes Nov 22, 2021
View reviewed changes
Copy link

@mbhenaff mbhenaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me!

@samvelyan samvelyan merged commit 5b1d9f9 into main Nov 22, 2021
@samvelyan samvelyan deleted the samvelyan/minigrid branch November 22, 2021 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbhenaff mbhenaff mbhenaff approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. envs Contributions to MiniHack environments
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@samvelyan @mbhenaff @facebook-github-bot