Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port NetHack Sokoban #101

Merged
merged 8 commits into from
Feb 15, 2024
Merged

Conversation

BartekCupial
Copy link
Contributor

NetHack Sokoban

Introduction

I have added 8 Sokoban levels to the MiniHack based on the dat file from NLE. These levels are challenging and have solutions available in the NetHack Wiki, making them useful for research on combining external knowledge to learn strategies for NetHack.

Changes to Original NetHack Sokoban Levels

  • All "wholes" have been changed into pits.
  • Falling into a pit results in the agent's death.
  • There are no monsters or items in any of the levels, including 4a and 4b Sokoban levels, which normally spawn a zoo filled with monsters.
  • All doors are closed, but none are locked.

Reward shaping and termination

The environment is completed when all pits are filled and the agent steps on the stairs down.
The agent receives a +1 reward for finishing the episode and a +0.1 reward for filling each pit.

@facebook-github-bot
Copy link

Hi @BartekCupial!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@github-actions github-actions bot added core envs Contributions to MiniHack environments tests Contributions to our tests. labels Feb 14, 2024
@samvelyan
Copy link
Member

Hi @BartekCupial. Many thanks for this wonderful PR. Could you please sign the Facebook CLA above so that we can proceed?

@BartekCupial
Copy link
Contributor Author

I've already done it. Not sure why it is not checked.

@samvelyan samvelyan self-requested a review February 14, 2024 16:08
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 14, 2024
@BartekCupial
Copy link
Contributor Author

@samvelyan CLA is signed now, but I see that there is a test on macos that failed. I don't have access to this kind of hardware. Can you help?

Copy link
Member

@samvelyan samvelyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@samvelyan
Copy link
Member

Tests pass now. Thank you very much for your contribution @BartekCupial

@samvelyan samvelyan merged commit 27e5ef2 into facebookresearch:main Feb 15, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. core envs Contributions to MiniHack environments tests Contributions to our tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants