-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port NetHack Sokoban #101
Port NetHack Sokoban #101
Conversation
Hi @BartekCupial! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
Hi @BartekCupial. Many thanks for this wonderful PR. Could you please sign the Facebook CLA above so that we can proceed? |
I've already done it. Not sure why it is not checked. |
@samvelyan CLA is signed now, but I see that there is a test on macos that failed. I don't have access to this kind of hardware. Can you help? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Tests pass now. Thank you very much for your contribution @BartekCupial |
NetHack Sokoban
Introduction
I have added 8 Sokoban levels to the MiniHack based on the dat file from NLE. These levels are challenging and have solutions available in the NetHack Wiki, making them useful for research on combining external knowledge to learn strategies for NetHack.
Changes to Original NetHack Sokoban Levels
Reward shaping and termination
The environment is completed when all pits are filled and the agent steps on the stairs down.
The agent receives a +1 reward for finishing the episode and a +0.1 reward for filling each pit.