-
Notifications
You must be signed in to change notification settings - Fork 420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Magnum to latest #2243
Merged
Merged
Update Magnum to latest #2243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaces zstd bundled with Basis, as that one is severely outdated. Using version 1.5.0 instead of the latest, as the latest doesn't build on the ancient Emscripten version used on the CI.
mosra
force-pushed
the
update-magnum28
branch
from
October 19, 2023 09:19
e9bb5e6
to
6a6236d
Compare
The renamed function does the same as the old one (which is now deprecated), it's just named appropriately because it always returned a half angle.
mosra
force-pushed
the
update-magnum28
branch
from
October 19, 2023 10:42
6a6236d
to
5c2ea4d
Compare
facebook-github-bot
added
the
CLA Signed
Do not delete this pull request or issue due to inactivity.
label
Oct 19, 2023
jturner65
approved these changes
Oct 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Glad to see the Near/Far plane calcs make it in to Habitat finally.
0mdc
approved these changes
Oct 22, 2023
Skylion007
approved these changes
Oct 22, 2023
aclegg3
approved these changes
Oct 24, 2023
This was referenced Oct 26, 2023
rpartsey
added a commit
to facebookresearch/habitat-lab
that referenced
this pull request
Oct 31, 2023
…cludes the above-mentioned better atlas packer)
rpartsey
added a commit
to facebookresearch/habitat-lab
that referenced
this pull request
Nov 1, 2023
* decrease GlyphCache after facebookresearch/habitat-sim#2243 (which includes the above-mentioned better atlas packer)
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Update of the Magnum submodules containing changes from the last 4+ months.
std::vector<std::string>
argument 😱<utility>
and<tuple>
in more placesMath::angle()
for quaternions was deprecated as it's actually returning a half-angle. Math::halfAngle() should be used now instead as it's named appropriately (andmath.half_angle()
in case of Python), anangle()
function returning a full angle will be reintroduced after enough time passes to make sure it doesn't change behavior of existing code.T{}
didn't work with classes that had a base with an explicit constructor.NV_geometry_shader_passthrough
extensionGL::MeshView
How Has This Been Tested
📗