Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documenting habitat test scenes and pointnav episodes #916

Merged
merged 2 commits into from
Aug 13, 2022

Conversation

srama2512
Copy link
Contributor

Motivation and Context

Documents how habitat test scenes and pointnav episodes can be downloaded.

How Has This Been Tested

Tested locally.

Types of changes

  • Docs change

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Jul 29, 2022
```
python -m habitat_sim.utils.datasets_download --uids habitat_test_scenes
```

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't want to expand the scope of your PR too much, but I think we should kill this entire section in the README (from ReplicaCAD to Habitat test scenes) and simply refer people to Habitat-Sim/Dataset.md. This will avoid duplication.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can take a stab at this, sure.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dhruvbatra - What do you think about the latest commit? I can also remove the pointnav dataset download instructions from habitat-sim/DATASETS.md (see below) since it isn't very relevant there.

https://github.com/facebookresearch/habitat-sim/pull/1821/files#diff-2f3570bea2b91e76817d6b45586c34747ad6b9f463bb8563d85c519fb7e36c29R11-R16

@dhruvbatra
Copy link
Contributor

Both look great. Thank you!

@dhruvbatra dhruvbatra merged commit e074ef8 into facebookresearch:main Aug 13, 2022
dannymcy pushed a commit to dannymcy/habitat-lab that referenced this pull request Jul 8, 2024
…ch#916)

* documenting habitat test scenes + pointnav episodes

* removed repeated scene-dataset download instructions, added pointer to habitat-sim
HHYHRHY pushed a commit to SgtVincent/habitat-lab that referenced this pull request Aug 31, 2024
…ch#916)

* documenting habitat test scenes + pointnav episodes

* removed repeated scene-dataset download instructions, added pointer to habitat-sim
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants