Fix more incorrect typehints in Habitat Core #535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
erikwijmans
reviewed
Nov 25, 2020
erikwijmans
approved these changes
Dec 3, 2020
srama2512
pushed a commit
that referenced
this pull request
Mar 15, 2023
Making links work on the website
dannymcy
pushed a commit
to dannymcy/habitat-lab
that referenced
this pull request
Jul 8, 2024
* Try to enable typeguard and more typing fixes * Fix more typing issues * Fix flake8 errors * Fix VisualObservations * Add habitat_sim to mypy.ini * Redisable typeguard * Make Torch soft dependency again
HHYHRHY
pushed a commit
to SgtVincent/habitat-lab
that referenced
this pull request
Aug 31, 2024
* Try to enable typeguard and more typing fixes * Fix more typing issues * Fix flake8 errors * Fix VisualObservations * Add habitat_sim to mypy.ini * Redisable typeguard * Make Torch soft dependency again
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
I verified a bunch of the typehints using typeguard and caught numerous issues in habitat.core . I went ahead fixed most of these issues. I also enabled including habitat_sim in the mypy type checker so we get any errors at the interface between habitat-lab and habitat-sim.
How Has This Been Tested
Typeguard + MYPY
Types of changes
Checklist