Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose all habitat-lab API docs #1779

Merged
merged 1 commit into from
Jan 30, 2024
Merged

Expose all habitat-lab API docs #1779

merged 1 commit into from
Jan 30, 2024

Conversation

henrysamer
Copy link
Contributor

Motivation and Context

Completed exposing docstrings within habitat-lab/habitat-lab/habitat to prepare for refactoring

##Pending Issues:
The following files are still not exposed:

habitat-lab/habitat-lab/habitat/core/spaces.py
habitat-lab/habitat-lab/habitat/sims/pyrobot/pyrobot.py

Checklist

  • [ x] My code follows the code style of this project.
  • [x ] I have updated the documentation if required.
  • [x ] I have read the CONTRIBUTING document.
  • [ x] I have completed my CLA (see CONTRIBUTING)
  • [ x] I have added tests to cover my changes if required.

@henrysamer henrysamer self-assigned this Jan 30, 2024
@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Jan 30, 2024
@mosra
Copy link
Contributor

mosra commented Jan 30, 2024

Apologies for the build breakage, you may want to rebase on top of current main (containing #1776) to fix the CI.

@henrysamer henrysamer marked this pull request as ready for review January 30, 2024 20:57
aclegg3
aclegg3 approved these changes Jan 30, 2024
View reviewed changes
Copy link
Contributor

@aclegg3 aclegg3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks 😃

@henrysamer henrysamer merged commit 9a30e8f into main Jan 30, 2024
4 checks passed
dannymcy pushed a commit to dannymcy/habitat-lab that referenced this pull request Jul 8, 2024
@henrysamer
expose all habitat-lab API docs (facebookresearch#1779)
4d2d2e6
HHYHRHY pushed a commit to SgtVincent/habitat-lab that referenced this pull request Aug 31, 2024
@henrysamer
expose all habitat-lab API docs (facebookresearch#1779)
8639eeb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aclegg3 aclegg3 aclegg3 approved these changes

@mosra mosra Awaiting requested review from mosra

Assignees

@henrysamer henrysamer

Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@henrysamer @mosra @aclegg3 @facebook-github-bot