Added ccache to CI and fixed PyTorch caching #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathfac
requested review from
abhiskk,
apsdehal,
erikwijmans and
JasonJiazhiZhang
facebook-github-bot
added
the
CLA Signed
apsdehal
approved these changes
Jul 17, 2019
.circleci/config.yml
Outdated
| paths: | ||
| - ~/miniconda | ||
| - run: | ||
| name: ccache stats |
There was a problem hiding this comment.
Suggested change
| name: ccache stats | |
| name: CCache Stats |
erikwijmans
suggested changes
Jul 17, 2019
.circleci/config.yml
Outdated
| @@ -107,6 +107,19 @@ jobs: | |||
| - restore_cache: | |||
| keys: | |||
| - habitat-sim-{{ checksum "./hsim_sha" }} | |||
| - restore_cache: | |||
| keys: | |||
| - ccache-{{ arch }}-{{ .Branch }}-{{ epoch }} | |||
There was a problem hiding this comment.
Won't this not work as {{ epoch }} is the current time and the cache-key will forever be different? Since this is the API, probably ccache-{{ arch }}-{{ checksum "./hsim_sha" }} makes sense as the key.
There was a problem hiding this comment.
Actually, it should just be ccache-{{ arch }} as the install of the simulator is already cached.
.circleci/config.yml
Outdated
| paths: | ||
| - ./habitat-sim | ||
| - save_cache: | ||
| key: ccache-{{ arch }}-{{ .Branch }}-{{ epoch }} |
There was a problem hiding this comment.
Same comment about the key.
mathfac
force-pushed
the
ci_fix_caching
branch
2 times, most recently
from
8df0996
to
8a2dd4c
Compare
mathfac
changed the title
erikwijmans
approved these changes
Jul 17, 2019
dhruvbatra
pushed a commit
that referenced
this pull request
May 10, 2020
* viewer: access pathfinder only if it's actually loaded. * assets: don't crash on relative house.json paths.
dannymcy
pushed a commit
to dannymcy/habitat-lab
that referenced
this pull request
Jul 8, 2024
* fixed PyTorch caching * added ccache to CI * broke habitat api step on installation and testing to save extra 5 min on saving cache in parallel * testing time drops from first run to second run from 17.5 minutes to 9 minutes (2x times) for full testing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The testing time drops from first run to second run from 17.5 minutes to 9 minutes (2x times) for full testing.
How Has This Been Tested
Types of changes
Checklist