Added requirements install step for sim installation in CI setup. #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
erikwijmans
approved these changes
Jul 16, 2019
JasonJiazhiZhang
added a commit
to JasonJiazhiZhang/habitat-api
that referenced
this pull request
Jul 16, 2019
* Update Habitat-API to allow for no rendering sensors (facebookresearch#139) Update Habitat-API to allow for no rendering sensors * Added installation requirements step for sim installation in CI setup. (facebookresearch#159) Added installation requirements step for sim installation in CI setup
abhiskk
pushed a commit
that referenced
this pull request
Jul 22, 2019
* refactor and add generic trainer class * fix to pass tests * change BaseModel to BaseTrainer * fix tensorboard import causing CI failure * modify circle-ci test script accordingly * doc, typing and other changes * rename BASELINE to TRAINER * merge from upstream master * Update Habitat-API to allow for no rendering sensors (#139) Update Habitat-API to allow for no rendering sensors * Added installation requirements step for sim installation in CI setup. (#159) Added installation requirements step for sim installation in CI setup * move RolloutStorage to utils * add environments.py * make ckpt dir if not exist * small fixes according to comments * changes according to comments * update readme * fix old config compatibility * fix missed isort lint
dhruvbatra
pushed a commit
that referenced
this pull request
May 10, 2020
The CI happily continues running pytest even if the build fails. That is *not* wanted.
dannymcy
pushed a commit
to dannymcy/habitat-lab
that referenced
this pull request
Jul 8, 2024
facebookresearch#159) Added installation requirements step for sim installation in CI setup
dannymcy
pushed a commit
to dannymcy/habitat-lab
that referenced
this pull request
Jul 8, 2024
…earch#153) * refactor and add generic trainer class * fix to pass tests * change BaseModel to BaseTrainer * fix tensorboard import causing CI failure * modify circle-ci test script accordingly * doc, typing and other changes * rename BASELINE to TRAINER * merge from upstream master * Update Habitat-API to allow for no rendering sensors (facebookresearch#139) Update Habitat-API to allow for no rendering sensors * Added installation requirements step for sim installation in CI setup. (facebookresearch#159) Added installation requirements step for sim installation in CI setup * move RolloutStorage to utils * add environments.py * make ckpt dir if not exist * small fixes according to comments * changes according to comments * update readme * fix old config compatibility * fix missed isort lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Added requirements install step for sim installation in CI setup to fix CI build.
During CI run lately we get an error during quaternion dependency installation:
I checked that the error happens also on old commit in master that was passing before.
The fix here is to install simulator python dependencies through the pip.
The error is also related to issue facebookresearch/habitat-sim#95.
Types of changes
Checklist